Re: [PATCH] char: ppdev: fixed a validation issue

[Greg KH]

On Tue, Nov 09, 2021 at 11:21:39PM +0530, Vihas Mak wrote:
> > And you didn't answer my question above, what happens if the mode is not
> > set properly today?
> 
> It'll throw a ENOSYS if the mode is not set properly and print the following:
> 
> pr_debug("%s: Unknown mode 0x%02x\n",
>              port->name, port->ieee1284.mode);

Ah, good, so then your change is not needed at all, so why add it?

thanks,

greg k-h