Re: [PATCH 1/3] x86/amd_nb: Add AMD Family 19h Models (10h-1Fh) and (A0h-AFh) PCI IDs

From: Babu Moger
Date: Tue Nov 09 2021 - 09:59:24 EST


Hi Krzysztof,

On 11/8/21 6:10 PM, Krzysztof Wilczyński wrote:
> Hello!
>
>> Add the new PCI Device IDs to support new generation of AMD 19h family of
>> processors.
> This commit message matches the spirit of past additions very well, as per:
>
> commit b3f79ae45904 ("x86/amd_nb: Add Family 19h PCI IDs")
>
> Admittedly, it would be nice to know what platform and/or generations of
> AMD family of CPUs this is for. Unless this is somewhat confidential and
> in which case it would be fair enough.
Yea. It is kind of confidential to spell out the platform at this point.
>
> For the following PCI related changes:
>
> [...]
>> --- a/include/linux/pci_ids.h
>> +++ b/include/linux/pci_ids.h
>> @@ -555,6 +555,7 @@
>> #define PCI_DEVICE_ID_AMD_17H_M60H_DF_F3 0x144b
>> #define PCI_DEVICE_ID_AMD_17H_M70H_DF_F3 0x1443
>> #define PCI_DEVICE_ID_AMD_19H_DF_F3 0x1653
>> +#define PCI_DEVICE_ID_AMD_19H_M10H_DF_F3 0x14b0
>> #define PCI_DEVICE_ID_AMD_19H_M40H_DF_F3 0x167c
>> #define PCI_DEVICE_ID_AMD_19H_M50H_DF_F3 0x166d
>> #define PCI_DEVICE_ID_AMD_CNB17H_F3 0x1703
> Acked-by: Krzysztof Wilczyński <kw@xxxxxxxxx>
> Thanks
> Babu Moger