Re: [PATCH 1/3] i915/gvt: seperate tracked MMIO table from handlers.c

From: Wang, Zhi A
Date: Tue Nov 09 2021 - 06:02:36 EST


On 11/9/2021 12:58 PM, hch@xxxxxx wrote:
> On Tue, Nov 09, 2021 at 10:51:27AM +0000, Wang, Zhi A wrote:
>> Can you elaborate more about this? We need the hash query from the table
>> ASAP when the hypervisor trapped a mmio access. It's a critical path and
>> we tried different data structure in the kernel and the hash table gives
>> the best performance.
> Ok, I misunderstood the hashtable.h interface. hash_for_each_possible
> actually does a hash lookup instead of an interation despite the rather
> misleading name.

Yes. Maybe with a keyword "lookup" in the name of the interface would be
better since it's widely used in the kernel. :)