Re: [PATCH 2/3] arm64: dts: renesas: r9a07g044: Add SCI[0-1] nodes

From: Lad, Prabhakar
Date: Mon Nov 08 2021 - 19:23:23 EST


Hi Geert,

Thank you for the review.

On Mon, Nov 8, 2021 at 4:26 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> On Wed, Nov 3, 2021 at 8:56 PM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote:
> > Add SCI[0-1] nodes to r9a07g044 (RZ/G2L) SoC DTSI.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
>
> > --- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> > @@ -176,6 +176,36 @@
> > status = "disabled";
> > };
> >
> > + sci0: serial@1004d000 {
>
> Please keep sort order (by unit address, but grouped by type).
>
Oops missed that, will fix it in v2.

Chers,
Prabhakar

> With the above fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds