Re: [PATCH 2/3] dt-bindings: serial: renesas,sci: Document RZ/G2L SoC

From: Lad, Prabhakar
Date: Mon Nov 08 2021 - 19:20:08 EST


Hi Geert,

On Mon, Nov 8, 2021 at 4:21 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> On Wed, Nov 3, 2021 at 6:31 PM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote:
> > Add SCI binding documentation for Renesas RZ/G2L SoC.
> >
> > Also update the example node with real world DT node.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
>
> > --- a/Documentation/devicetree/bindings/serial/renesas,sci.yaml
> > +++ b/Documentation/devicetree/bindings/serial/renesas,sci.yaml
>
> > @@ -54,18 +58,45 @@ required:
> > - clocks
> > - clock-names
> >
> > +if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - renesas,r9a07g044-sci
> > +then:
> > + properties:
> > + resets:
> > + maxItems: 1
> > +
> > + power-domains:
> > + maxItems: 1
> > +
> > + required:
> > + - resets
> > + - power-domains
>
> We really should make interrupt-names required everywhere, after
> fixing the H8/300 DTS files.
>
Agreed, also in other scif*.yaml files this needs fixing.

Cheers,
Prabhakar

> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds