RE: [PATCH 1/2] dt-binding: mmc: Add mmc yaml file for Sunplus SP7021

[Tony Huang 黃懷厚]

Dear Rob:

> Subject: Re: [PATCH 1/2] dt-binding: mmc: Add mmc yaml file for Sunplus
> SP7021
> 
> On Sat, Nov 06, 2021 at 10:23:17PM +0800, Tony Huang wrote:
> > Add mmc yaml file for Sunplus SP7021
> >
> > Signed-off-by: Tony Huang <tony.huang@xxxxxxxxxxx>
> > ---
> >  .../devicetree/bindings/mmc/sunplus-mmc.yaml       | 64
> ++++++++++++++++++++++
> >  MAINTAINERS                                        |  5 ++
> >  2 files changed, 69 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/mmc/sunplus-mmc.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/sunplus-mmc.yaml
> > b/Documentation/devicetree/bindings/mmc/sunplus-mmc.yaml
> > new file mode 100644
> > index 0000000..fc5a5f6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mmc/sunplus-mmc.yaml
> > @@ -0,0 +1,64 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) # Copyright
> > +(C) Sunplus Ltd. Co. 2021 %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mmc/sunplus-mmc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: sunplus MMC controller
> > +
> > +allOf:
> > +  - $ref: "mmc-controller.yaml"
> > +
> > +maintainers:
> > +  - tony.huang <tony.huang@xxxxxxxxxxx>
> 
> Please fix your name.
OK,I will fix.

> 
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - sunplus,sp7021-emmc
> > +      - sunplus,i143-emmc
> > +      - sunplus,q645-emmc
> 
> blank line here.
OK,I will add blank line.
> 
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    minItems: 1
> > +
> > +  resets:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - clocks
> > +  - resets
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    #include <dt-bindings/clock/sp-sp7021.h>
> > +    #include <dt-bindings/reset/sp-sp7021.h>
> > +    mmc0: mmc@9c003b00 {
> > +        compatible = "sunplus,sp7021-emmc";
> > +        reg = <0x9c003b00 0x180>;
> > +        interrupts = <20 IRQ_TYPE_LEVEL_HIGH>;
> > +        clocks = <&clkc CARD_CTL0>;
> > +        resets = <&rstc RST_CARD_CTL0>;
> > +        bus-width = <8>;
> > +        max-frequency = <52000000>;
> > +        non-removable;
> > +        disable-wp;
> > +        cap-mmc-highspeed;
> > +        mmc-ddr-3_3v;
> > +        no-sdio;
> > +        no-sd;
> > +    };
> > +...
> > diff --git a/MAINTAINERS b/MAINTAINERS index 3b79fd4..179e60a 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -17945,6 +17945,11 @@ L:	netdev@xxxxxxxxxxxxxxx
> >  S:	Maintained
> >  F:	drivers/net/ethernet/dlink/sundance.c
> >
> > +SUNPLUS MMC DRIVER
> > +M:	Tony Huang <tony.huang@xxxxxxxxxxx>
> > +S:	Maintained
> > +F:	Documentation/devicetree/bindings/mmc/sunplu-mmc.yaml
> > +
> >  SUPERH
> >  M:	Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>
> >  M:	Rich Felker <dalias@xxxxxxxx>
> > --
> > 2.7.4
> >
> >