Re: [patch 099/262] mm/vmalloc: be more explicit about supported gfp flags

From: Michal Hocko
Date: Mon Nov 08 2021 - 12:30:13 EST


On Mon 08-11-21 09:15:04, Linus Torvalds wrote:
> On Mon, Nov 8, 2021 at 1:25 AM Michal Hocko <mhocko@xxxxxxxx> wrote:
> >
> > As already pointed out
> > http://lkml.kernel.org/r/YXE+hcodJ7zxeYA7@xxxxxxxxxxxxxx this patch
> > cannot be applied without other patches from the same series.
>
> Hmm. I've taken it already.
>
> Not a huge deal, since it's a comment change - and the code will
> presumably eventually match the updated comment.

I plan to send the rest after the merge window.

> I guess it's a new thing that instead of stale comments, we have
> future-proof ones ;)

I just hope nobody gets confused about which are not supported yet. E.g.
GFP_NOFAIL, GFP_NO{FS,IO}. In both cases the direct use could lead to
bugs.
--
Michal Hocko
SUSE Labs