[PATCH] media: atomisp: only initialize mode if pipe is not null

From: Mauro Carvalho Chehab
Date: Mon Nov 08 2021 - 04:40:33 EST


During atomisp register, udev tries to open all devices. For
some, pipe is NULL, at least during register time, causing the
driver to try to access a NULL pointer.

So, add an extra check to avoid such condition.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
---
drivers/staging/media/atomisp/pci/atomisp_fops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/pci/atomisp_fops.c b/drivers/staging/media/atomisp/pci/atomisp_fops.c
index a57d480820bd..c7ac313a2edf 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_fops.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_fops.c
@@ -901,7 +901,7 @@ static int atomisp_open(struct file *file)
rt_mutex_unlock(&isp->mutex);

/* Ensure that a mode is set */
- if (asd)
+ if (asd && pipe)
v4l2_ctrl_s_ctrl(asd->run_mode, pipe->default_run_mode);

return 0;
--
2.33.1