Re: [RFC 2/3] gpiolib: remove empty asm/gpio.h files

From: Geert Uytterhoeven
Date: Mon Nov 08 2021 - 03:07:46 EST


Hi Arnd,

On Fri, Nov 5, 2021 at 2:04 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The arm and sh versions of this file are identical to the generic
> versions and can just be removed.
>
> The drivers that actually use the sh3 specific version also include
> cpu/gpio.h directly. This leaves coldfire as the only gpio driver

All but arch/sh/boards/board-magicpanelr2.c do. So that one needs
a direct inclusion of <cpu/gpio.h>.

> that needs something custom for gpiolib.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

With the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds