RE: [RFC PATCH v2 5/5] docs: ABI: Add sysfs documentation interface of hardware prefetch driver

From: tarumizu.kohei@xxxxxxxxxxx
Date: Sun Nov 07 2021 - 20:37:05 EST


Hi,

Thanks for your comment.

> How does this look in practice?

It works on a x86 machine is shown below:

# find /sys/devices/system/cpu/cpu0/hwpf/
/sys/devices/system/cpu/cpu0/hwpf/
/sys/devices/system/cpu/cpu0/hwpf/l2
/sys/devices/system/cpu/cpu0/hwpf/l2/enable
/sys/devices/system/cpu/cpu0/hwpf/l1
/sys/devices/system/cpu/cpu0/hwpf/l1/enable

> Dumb question, but why don't we give these things names? If the Intel one is
> called "L2 Hardware Prefetcher Disable", couldn't the directory be "l2_prefetch"?

There is no specific reason for directory names. We named it "l*"
because it is related to a certain cache level. We would change it,
if there is another suitable name.

> BTW, your "reliable" is mismatched with the "strong" value in the docs.

Sorry, that's our mistake. The "strong" is correct.