Re: [PATCH v3 0/5] Refactor thermal pressure update to avoid code duplication

From: Steev Klimaszewski
Date: Fri Nov 05 2021 - 11:39:19 EST

Next message: Maxim Levitsky: "Re: [PATCH v3 1/4] KVM: nVMX: Don't use Enlightened MSR Bitmap for L3"
Previous message: Mark Brown: "Re: [PATCH 3/4] ASoC: mediatek: mt8195: separate the common code from machine driver"
In reply to: Lukasz Luba: "[PATCH v3 5/5] arch_topology: Remove unused topology_set_thermal_pressure() and related"
Next in thread: Lukasz Luba: "Re: [PATCH v3 0/5] Refactor thermal pressure update to avoid code duplication"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi Lukasz,

On 11/3/21 11:10 AM, Lukasz Luba wrote:

Hi all,

This patch set v3 aims to refactor the thermal pressure update
code. There are already two clients which do similar thing:
convert the capped frequency value into the capacity of
affected CPU and call the 'set' function to store the
reduced capacity into the per-cpu variable.
There might be more than two of these users. In near future
it will be scmi-cpufreq driver, which receives notification
from FW about reduced frequency due to thermal. Other vendors
might follow. Let's avoid code duplication and potential
conversion bugs. Move the conversion code into the arch_topology.c
where the capacity calculation setup code and thermal pressure sit.

Apart from that $subject patches, there is one patch (3/5) which fixes
issue in qcom-cpufreq-hw.c when the thermal pressure is not
updated for offline CPUs. It's similar fix that has been merged
recently for cpufreq_cooling.c:
2ad8ccc17d1e4270cf65a3f2

Changes:
v3:
- added warning and check if provided capped frequency is lower than
max (Viresh)
- removed check for empty cpu mask (Viresh)
- replaced tabs with spaces in the doxygen comment (Viresh)
- renamed {arch|topology}_thermal_pressure_update() to
{arch|topology}_update_thermal_pressure() so it's align with scheme (Dietmar)
- added info about MHz in freq_factor into patch description (Dietmar)
v2 [2]:
- added Reviewed-by from Thara for patch 3/5
- changed the doxygen comment and used mult_frac()
according to Thara's suggestion in patch 1/5
v1 -> [1]

Regards,
Lukasz Luba

[1] https://lore.kernel.org/linux-pm/20211007080729.8262-1-lukasz.luba@xxxxxxx/
[2] https://lore.kernel.org/linux-pm/20211015144550.23719-1-lukasz.luba@xxxxxxx/

Lukasz Luba (5):
arch_topology: Introduce thermal pressure update function
thermal: cpufreq_cooling: Use new thermal pressure update function
cpufreq: qcom-cpufreq-hw: Update offline CPUs per-cpu thermal pressure
cpufreq: qcom-cpufreq-hw: Use new thermal pressure update function
arch_topology: Remove unused topology_set_thermal_pressure() and
related

arch/arm/include/asm/topology.h | 2 +-
arch/arm64/include/asm/topology.h | 2 +-
drivers/base/arch_topology.c | 36 +++++++++++++++++++++++++++----
drivers/cpufreq/qcom-cpufreq-hw.c | 14 +++++-------
drivers/thermal/cpufreq_cooling.c | 6 +-----
include/linux/arch_topology.h | 4 ++--
include/linux/sched/topology.h | 6 +++---
init/Kconfig | 2 +-
8 files changed, 46 insertions(+), 26 deletions(-)

I've been testing this patchset on the Lenovo Yoga C630, and today while compiling alacritty and running an apt-get full-upgrade, I found the following in dmesg output:

[ 194.343903] ------------[ cut here ]------------
[ 194.343912] WARNING: CPU: 4 PID: 192 at drivers/base/arch_topology.c:188 topology_update_thermal_pressure+0xe4/0x100
[ 194.343928] Modules linked in: aes_ce_ccm snd_seq_dummy snd_hrtimer snd_seq snd_seq_device algif_hash algif_skcipher af_alg bnep cpufreq_ondemand cpufreq_conservative cpufreq_powersave cpufreq_userspace lz4 lz4_compress zram zsmalloc q6asm_dai q6routing q6afe_dai q6adm q6asm q6afe q6dsp_common snd_soc_wsa881x q6core regmap_sdw snd_soc_wcd934x gpio_wcd934x soundwire_qcom snd_soc_wcd_mbhc wcd934x regmap_slimbus uvcvideo videobuf2_vmalloc venus_enc venus_dec videobuf2_dma_contig videobuf2_memops qrtr_smd fastrpc apr binfmt_misc nls_ascii nls_cp437 vfat fat snd_soc_sdm845 snd_soc_rt5663 snd_soc_qcom_common pm8941_pwrkey joydev snd_soc_rl6231 aes_ce_blk qcom_spmi_adc5 soundwire_bus qcom_vadc_common crypto_simd qcom_spmi_temp_alarm snd_soc_core cryptd hci_uart snd_compress btqca industrialio aes_ce_cipher snd_pcm_dmaengine btrtl crct10dif_ce btbcm ghash_ce snd_pcm btintel gf128mul sha2_ce snd_timer venus_core bluetooth snd v4l2_mem2mem sha256_arm64 videobuf2_v4l2 videobuf2_common soundcore
[ 194.344007] sha1_ce videodev ecdh_generic ecc mc ath10k_snoc ath10k_core hid_multitouch ath mac80211 qcom_rng libarc4 qcom_q6v5_mss cfg80211 sg rfkill qcom_q6v5_pas qcom_pil_info slim_qcom_ngd_ctrl qcom_wdt pdr_interface qcom_q6v5 evdev rmtfs_mem slimbus qcom_sysmon fuse configfs qrtr ip_tables x_tables autofs4 ext4 mbcache jbd2 panel_simple rtc_pm8xxx msm llcc_qcom ocmem gpu_sched ti_sn65dsi86 drm_dp_aux_bus drm_kms_helper drm camcc_sdm845 ipa qcom_common qmi_helpers mdt_loader gpio_keys pwm_bl
[ 194.344056] CPU: 4 PID: 192 Comm: kworker/4:1H Not tainted 5.15.0 #9
[ 194.344060] Hardware name: LENOVO 81JL/LNVNB161216, BIOS 9UCN33WW(V2.06) 06/ 4/2019
[ 194.344062] Workqueue: events_highpri qcom_lmh_dcvs_poll
[ 194.344068] pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[ 194.344070] pc : topology_update_thermal_pressure+0xe4/0x100
[ 194.344073] lr : topology_update_thermal_pressure+0x30/0x100
[ 194.344075] sp : ffff800014043d10
[ 194.344076] x29: ffff800014043d10 x28: 0000000000000000 x27: 0000000000000000
[ 194.344080] x26: ffff759c40b66974 x25: ffff759db37a2405 x24: ffff759c40e83358
[ 194.344084] x23: 0000000000000000 x22: ffffb2699eafe1d8 x21: 00000000002d1e00
[ 194.344087] x20: ffff759c49f5bc20 x19: 000000000000b8cc x18: 0000000000000000
[ 194.344090] x17: 2f756e672d78756e x16: ffffb2699d7d83d0 x15: 0000000000000000
[ 194.344093] x14: 0000000000000000 x13: 0000000000000030 x12: 0101010101010101
[ 194.344096] x11: 7f7f7f7f7f7f7f7f x10: feff68716f676668 x9 : ffffb2699dd66a58
[ 194.344099] x8 : fefefefefefefeff x7 : 000000000000000f x6 : 0000000000000002
[ 194.344102] x5 : ffffc33415124000 x4 : 0000000000000400 x3 : 0000000000000b19
[ 194.344105] x2 : 0000000000000b8c x1 : ffffb2699e678f40 x0 : ffffb2699e678f48
[ 194.344108] Call trace:
[ 194.344110] topology_update_thermal_pressure+0xe4/0x100
[ 194.344113] qcom_lmh_dcvs_notify+0xc8/0x160
[ 194.344115] qcom_lmh_dcvs_poll+0x20/0x2c
[ 194.344116] process_one_work+0x1f4/0x490
[ 194.344120] worker_thread+0x188/0x504
[ 194.344121] kthread+0x12c/0x140
[ 194.344125] ret_from_fork+0x10/0x20
[ 194.344128] ---[ end trace bd0039c4fb892d5b ]---
[ 194.344170] ------------[ cut here ]------------
[ 194.344171] WARNING: CPU: 4 PID: 161 at drivers/base/arch_topology.c:188 topology_update_thermal_pressure+0xe4/0x100
[ 194.344175] Modules linked in: aes_ce_ccm snd_seq_dummy snd_hrtimer snd_seq snd_seq_device algif_hash algif_skcipher af_alg bnep cpufreq_ondemand cpufreq_conservative cpufreq_powersave cpufreq_userspace lz4 lz4_compress zram zsmalloc q6asm_dai q6routing q6afe_dai q6adm q6asm q6afe q6dsp_common snd_soc_wsa881x q6core regmap_sdw snd_soc_wcd934x gpio_wcd934x soundwire_qcom snd_soc_wcd_mbhc wcd934x regmap_slimbus uvcvideo videobuf2_vmalloc venus_enc venus_dec videobuf2_dma_contig videobuf2_memops qrtr_smd fastrpc apr binfmt_misc nls_ascii nls_cp437 vfat fat snd_soc_sdm845 snd_soc_rt5663 snd_soc_qcom_common pm8941_pwrkey joydev snd_soc_rl6231 aes_ce_blk qcom_spmi_adc5 soundwire_bus qcom_vadc_common crypto_simd qcom_spmi_temp_alarm snd_soc_core cryptd hci_uart snd_compress btqca industrialio aes_ce_cipher snd_pcm_dmaengine btrtl crct10dif_ce btbcm ghash_ce snd_pcm btintel gf128mul sha2_ce snd_timer venus_core bluetooth snd v4l2_mem2mem sha256_arm64 videobuf2_v4l2 videobuf2_common soundcore
[ 194.344225] sha1_ce videodev ecdh_generic ecc mc ath10k_snoc ath10k_core hid_multitouch ath mac80211 qcom_rng libarc4 qcom_q6v5_mss cfg80211 sg rfkill qcom_q6v5_pas qcom_pil_info slim_qcom_ngd_ctrl qcom_wdt pdr_interface qcom_q6v5 evdev rmtfs_mem slimbus qcom_sysmon fuse configfs qrtr ip_tables x_tables autofs4 ext4 mbcache jbd2 panel_simple rtc_pm8xxx msm llcc_qcom ocmem gpu_sched ti_sn65dsi86 drm_dp_aux_bus drm_kms_helper drm camcc_sdm845 ipa qcom_common qmi_helpers mdt_loader gpio_keys pwm_bl
[ 194.344256] CPU: 4 PID: 161 Comm: irq/159-dcvsh-i Tainted: G W 5.15.0 #9
[ 194.344259] Hardware name: LENOVO 81JL/LNVNB161216, BIOS 9UCN33WW(V2.06) 06/ 4/2019
[ 194.344260] pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[ 194.344262] pc : topology_update_thermal_pressure+0xe4/0x100
[ 194.344264] lr : topology_update_thermal_pressure+0x30/0x100
[ 194.344266] sp : ffff800011e93cf0
[ 194.344267] x29: ffff800011e93cf0 x28: 0000000000000000 x27: 0000000000000000
[ 194.344270] x26: ffffb2699d4d0a80 x25: ffffb2699d4d0b60 x24: ffff759c40caec00
[ 194.344273] x23: ffff759c49f02c40 x22: ffffb2699eafe1d8 x21: 00000000002d1e00
[ 194.344276] x20: ffff759c49f5bc20 x19: 000000000000b8cc x18: 000000000000000e
[ 194.344280] x17: 0000000000000001 x16: 0000000000000019 x15: 0000000000000033
[ 194.344283] x14: 000000000000004c x13: 0000000000000068 x12: 0000000000000040
[ 194.344286] x11: ffff759c4049f478 x10: ffff759c4049f47a x9 : ffffb2699dd66a58
[ 194.344288] x8 : ffff759c40401dd0 x7 : 0000000000000000 x6 : 0000000000000002
[ 194.344291] x5 : ffffc33415124000 x4 : 0000000000000400 x3 : 0000000000000b19
[ 194.344294] x2 : 0000000000000b8c x1 : ffffb2699e678f40 x0 : ffffb2699e678f48
[ 194.344297] Call trace:
[ 194.344298] topology_update_thermal_pressure+0xe4/0x100
[ 194.344300] qcom_lmh_dcvs_notify+0xc8/0x160
[ 194.344302] qcom_lmh_dcvs_handle_irq+0x30/0x44
[ 194.344304] irq_thread_fn+0x38/0xb0
[ 194.344307] irq_thread+0x194/0x3b0
[ 194.344308] kthread+0x12c/0x140
[ 194.344311] ret_from_fork+0x10/0x20
[ 194.344313] ---[ end trace bd0039c4fb892d5c ]---
[ 194.405913] ------------[ cut here ]------------
[ 194.405923] WARNING: CPU: 4 PID: 192 at drivers/base/arch_topology.c:188 topology_update_thermal_pressure+0xe4/0x100
[ 194.405939] Modules linked in: aes_ce_ccm snd_seq_dummy snd_hrtimer snd_seq snd_seq_device algif_hash algif_skcipher af_alg bnep cpufreq_ondemand cpufreq_conservative cpufreq_powersave cpufreq_userspace lz4 lz4_compress zram zsmalloc q6asm_dai q6routing q6afe_dai q6adm q6asm q6afe q6dsp_common snd_soc_wsa881x q6core regmap_sdw snd_soc_wcd934x gpio_wcd934x soundwire_qcom snd_soc_wcd_mbhc wcd934x regmap_slimbus uvcvideo videobuf2_vmalloc venus_enc venus_dec videobuf2_dma_contig videobuf2_memops qrtr_smd fastrpc apr binfmt_misc nls_ascii nls_cp437 vfat fat snd_soc_sdm845 snd_soc_rt5663 snd_soc_qcom_common pm8941_pwrkey joydev snd_soc_rl6231 aes_ce_blk qcom_spmi_adc5 soundwire_bus qcom_vadc_common crypto_simd qcom_spmi_temp_alarm snd_soc_core cryptd hci_uart snd_compress btqca industrialio aes_ce_cipher snd_pcm_dmaengine btrtl crct10dif_ce btbcm ghash_ce snd_pcm btintel gf128mul sha2_ce snd_timer venus_core bluetooth snd v4l2_mem2mem sha256_arm64 videobuf2_v4l2 videobuf2_common soundcore
[ 194.406038] sha1_ce videodev ecdh_generic ecc mc ath10k_snoc ath10k_core hid_multitouch ath mac80211 qcom_rng libarc4 qcom_q6v5_mss cfg80211 sg rfkill qcom_q6v5_pas qcom_pil_info slim_qcom_ngd_ctrl qcom_wdt pdr_interface qcom_q6v5 evdev rmtfs_mem slimbus qcom_sysmon fuse configfs qrtr ip_tables x_tables autofs4 ext4 mbcache jbd2 panel_simple rtc_pm8xxx msm llcc_qcom ocmem gpu_sched ti_sn65dsi86 drm_dp_aux_bus drm_kms_helper drm camcc_sdm845 ipa qcom_common qmi_helpers mdt_loader gpio_keys pwm_bl
[ 194.406089] CPU: 4 PID: 192 Comm: kworker/4:1H Tainted: G W 5.15.0 #9
[ 194.406092] Hardware name: LENOVO 81JL/LNVNB161216, BIOS 9UCN33WW(V2.06) 06/ 4/2019
[ 194.406094] Workqueue: events_highpri qcom_lmh_dcvs_poll
[ 194.406101] pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[ 194.406104] pc : topology_update_thermal_pressure+0xe4/0x100
[ 194.406107] lr : topology_update_thermal_pressure+0x30/0x100
[ 194.406109] sp : ffff800014043d10
[ 194.406111] x29: ffff800014043d10 x28: 0000000000000000 x27: 0000000000000000
[ 194.406114] x26: ffff759c40b66974 x25: ffff759db37a2405 x24: ffff759c40e83358
[ 194.406117] x23: 0000000000000000 x22: ffffb2699eafe1d8 x21: 00000000002d1e00
[ 194.406120] x20: ffff759c49f5bc20 x19: 000000000000b8cc x18: 0000000000000000
[ 194.406123] x17: ffffc33415124000 x16: ffff800010024000 x15: 0000000000004000
[ 194.406126] x14: 0000000000000000 x13: 0000000000000030 x12: 0101010101010101
[ 194.406129] x11: 7f7f7f7f7f7f7f7f x10: feff68716f676668 x9 : ffffb2699dd66a58
[ 194.406132] x8 : fefefefefefefeff x7 : 000000000000000f x6 : 0000000000000002
[ 194.406135] x5 : ffffc33415124000 x4 : 0000000000000400 x3 : 0000000000000b19
[ 194.406138] x2 : 0000000000000b8c x1 : ffffb2699e678f40 x0 : ffffb2699e678f48
[ 194.406141] Call trace:
[ 194.406143] topology_update_thermal_pressure+0xe4/0x100
[ 194.406146] qcom_lmh_dcvs_notify+0xc8/0x160
[ 194.406148] qcom_lmh_dcvs_poll+0x20/0x2c
[ 194.406149] process_one_work+0x1f4/0x490
[ 194.406153] worker_thread+0x188/0x504
[ 194.406154] kthread+0x12c/0x140
[ 194.406158] ret_from_fork+0x10/0x20
[ 194.406162] ---[ end trace bd0039c4fb892d5d ]---

Next message: Maxim Levitsky: "Re: [PATCH v3 1/4] KVM: nVMX: Don't use Enlightened MSR Bitmap for L3"
Previous message: Mark Brown: "Re: [PATCH 3/4] ASoC: mediatek: mt8195: separate the common code from machine driver"
In reply to: Lukasz Luba: "[PATCH v3 5/5] arch_topology: Remove unused topology_set_thermal_pressure() and related"
Next in thread: Lukasz Luba: "Re: [PATCH v3 0/5] Refactor thermal pressure update to avoid code duplication"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]