Re: [RFC V2 0/5] arm64: dts: imx8mm: Enable CSI and OV5640 Camera

From: Fabio Estevam
Date: Fri Nov 05 2021 - 07:13:45 EST


Hi Adam,

On Fri, Nov 5, 2021 at 1:14 AM Adam Ford <aford173@xxxxxxxxx> wrote:

> +Lucas Stach
> I think I found the issue of the camera hanging. It appears to be
> related to the disp-blk-ctrl virtual power domains.
>
> In the NXP kernel, the dispmix power domain in ATF sets bits 16 and 17
> of 32e2_8008 (GPR_MIPI_RESET_DIV), but the disp-blk-ctl driver only
> configures 32e2_8000 (SFT_RSTN_CSR) and 32e2_8004 (CLK_EN_CSR). As
> soon as I set those extra bits, the hanging went away, and I got an
> image and the image looked good. I'll try to work on this tomorrow or
> the weekend to submit a patch with a fixes tag to make sure the
> IMX8MM_DISPBLK_PD_MIPI_CSI power domain properly configures the extra
> register.
>
> With this change, I didn't need to modify either the CSI-bridge driver
> nor the mipi_csi driver, so when I get the blk-ctrl fix, I'll resubmit
> this series on top of that with the corrections suggested as a proper
> patch without the RFC.

That's great news! Thanks a lot for your good work.

Cheers