[PATCH] drm/msm/devfreq: Fix OPP refcnt leak

From: Rob Clark
Date: Thu Nov 04 2021 - 18:23:50 EST


From: Rob Clark <robdclark@xxxxxxxxxxxx>

Reported-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
Fixes: 9bc95570175a ("drm/msm: Devfreq tuning")
Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx>
---
drivers/gpu/drm/msm/msm_gpu_devfreq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/msm/msm_gpu_devfreq.c b/drivers/gpu/drm/msm/msm_gpu_devfreq.c
index d32b729b4616..9bf8600b6eea 100644
--- a/drivers/gpu/drm/msm/msm_gpu_devfreq.c
+++ b/drivers/gpu/drm/msm/msm_gpu_devfreq.c
@@ -20,8 +20,6 @@ static int msm_devfreq_target(struct device *dev, unsigned long *freq,
struct msm_gpu *gpu = dev_to_gpu(dev);
struct dev_pm_opp *opp;

- opp = devfreq_recommended_opp(dev, freq, flags);
-
/*
* If the GPU is idle, devfreq is not aware, so just ignore
* it's requests
@@ -31,6 +29,8 @@ static int msm_devfreq_target(struct device *dev, unsigned long *freq,
return 0;
}

+ opp = devfreq_recommended_opp(dev, freq, flags);
+
if (IS_ERR(opp))
return PTR_ERR(opp);

--
2.31.1