RE: [PATCH 2/2] net: ethernet: Add driver for Sunplus SP7021

From: Wells Lu 呂芳騰
Date: Thu Nov 04 2021 - 15:04:25 EST


> > No, we only develop arm-based SoC, never for x86 or mips.
> > We never compile the driver for x86 or mips machine.
>
> You don't, but the Linux community does build for those architectures. Most
> people do tree wide refactoring work using x86. Tree wide cleanups using x86,
> etc. Any changes like that could touch your driver. The harder is it to build, the
> less build testing it will get, and tree wide changes which break it are less likely
> to get noticed. So you really do want it to compile cleanly for all
> architectures. If it does not, it normally actually means you are doing
> something wrong, something you need to fix anyway. So please do build it for
> x86 and make sure it builds cleanly.
>
> Andrew

Ok, I understand.
I'll add COMPILE_TEST and compile driver for x86.

Thanks,