Re: perf build broken looking for bpf/{libbpf,bpf}.h after merge with upstream

[Song Liu]

> On Nov 4, 2021, at 11:11 AM, Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
> 
> Em Thu, Nov 04, 2021 at 10:56:26AM -0700, Andrii Nakryiko escreveu:
>> On Thu, Nov 4, 2021 at 10:49 AM Arnaldo Carvalho de Melo <arnaldo.melo@xxxxxxxxx> wrote:
> 
>>> Em Thu, Nov 04, 2021 at 02:37:57PM -0300, Arnaldo Carvalho de Melo escreveu:
>>>> 
>>>> Hi Song,
>>>> 
>>>>      I just did a merge with upstream and I'm getting this:
>>>> 
>>>>  LINK    /tmp/build/perf/plugins/plugin_scsi.so
>>>>  INSTALL trace_plugins
>>> 
>>> To clarify, the command line to build perf that results in this problem
>>> is:
>>> 
>>>  make -k BUILD_BPF_SKEL=1 CORESIGHT=1 PYTHON=python3 O=/tmp/build/perf -C tools/perf install-bin
>> 
>> Oh, I dropped CORESIGN and left BUILD_BPF_SKEL=1 and yeah, I see the
>> build failure. I do think now that it's related to the recent Makefile
>> revamp effort. Quentin, PTAL.
>> 
>> On the side note, why BUILD_BPF_SKEL=1 is not a default, we might have
>> caught this sooner. Is there any reason not to flip the default?
> 
> I asked Song in the past about this, and asked again on another reply to
> this thread, I think it should be the default.
> 
> Song, Namhyung? You're the skel guys (so far) :-)

Yeah, let's make it default. 

Song