Re: [PATCH v2 0/2] ceph: metrics for remote object copies

From: Jeff Layton
Date: Thu Nov 04 2021 - 11:09:37 EST


On Thu, 2021-11-04 at 12:31 +0000, Luís Henriques wrote:
> Hi!
>
> Here's v2 of this patchset. The differences from v1:
>
> * Instead of changing ceph_osdc_copy_from() in libceph.ko to return an
> osd request, move that function into the cephfs code instead.
>
> Other than that, the 2nd patch is quite similar to the one from v1: it
> effectively hooks the 'copyfrom' metrics infrastructure.
>
> Luís Henriques (2):
> ceph: libceph: move ceph_osdc_copy_from() into cephfs code
> ceph: add a new metric to keep track of remote object copies
>
> fs/ceph/debugfs.c | 3 +-
> fs/ceph/file.c | 78 ++++++++++++++++++++++++++++-----
> fs/ceph/metric.h | 8 ++++
> include/linux/ceph/osd_client.h | 19 ++++----
> net/ceph/osd_client.c | 60 ++++---------------------
> 5 files changed, 94 insertions(+), 74 deletions(-)
>

Looks good. Thanks, Luis. Merged into testing branch.
--
Jeff Layton <jlayton@xxxxxxxxxx>