Re: [PATCH] mwifiex: Add quirk to disable deep sleep with certain hardware revision

[Jonas Dreßler]

On 11/3/21 13:25, Jonas Dreßler wrote:
> > > --- a/drivers/net/wireless/marvell/mwifiex/sta_cmdresp.c
> > > +++ b/drivers/net/wireless/marvell/mwifiex/sta_cmdresp.c
> > > @@ -708,6 +708,22 @@ static int mwifiex_ret_ver_ext(struct mwifiex_private *priv,
> > >   {
> > >          struct host_cmd_ds_version_ext *ver_ext = &resp->params.verext;
> > >
> > > +       if (test_and_clear_bit(MWIFIEX_IS_REQUESTING_FW_VEREXT, &priv->adapter->work_flags)) {
> > > +               if (strncmp(ver_ext->version_str, "ChipRev:20, BB:9b(10.00), RF:40(21)", 128) == 0) {
> >
> > Rather than memorize the 128-size array here, maybe use
> > sizeof(ver_ext->version_str) ?
>
> Sounds like a good idea, yeah.

Nevermind, the reason I did this was for consistency in the
function, right underneath in the same function it also assumes
a fixed size of 128 characters, so I'd rather use the same
length.

> 		memcpy(version_ext->version_str, ver_ext->version_str,
> 		       sizeof(char) * 128);
> 		memcpy(priv->version_str, ver_ext->version_str, 128);

Might be a good idea to #define it as MWIFIEX_VERSION_STR_LENGTH
in fw.h though...