Re: [PATCH 1/9] Remove unused headers <linux/jz4740-adc.h> and <linux/power/jz4740-battery.h>

[Paul Cercueil]

Hi Lee,

Le mer., nov. 3 2021 at 07:43:51 +0000, Lee Jones 
<lee.jones@xxxxxxxxxx> a écrit :
> On Tue, 02 Nov 2021, Jonathan Corbet wrote:
>
> >  Commit ff71266aa490 ("mfd: Drop obsolete JZ4740 driver") removed 
> > the last
> >  file to include <linux/jz4740-adc.h> but left the header file itself
> >  behind.  Nothing uses it, remove it now.
> >
> >  Similarly, aea12071d6fc ("power/supply: Drop obsolete JZ4740 
> > driver")
> >  deleted the last use of <linux/power/jz4740-battery.h>, so remove 
> > that one
> >  too.
> >
> >  Cc: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> >  Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> >  Cc: Paul Burton <paul.burton@xxxxxxxx>
> >  Cc: Sebastian Reichel <sre@xxxxxxxxxx>
> >  Cc: linux-pm@xxxxxxxxxxxxxxx
> >  Signed-off-by: Jonathan Corbet <corbet@xxxxxxx>
> >  ---
> >   include/linux/jz4740-adc.h           | 33 
> > ----------------------------
> >   include/linux/power/jz4740-battery.h | 15 -------------
>
> It appears as though there are still references to both of these
> *devices* in the kernel tree.  Should those be removed also?

These files were for older drivers that were since then replaced by 
newer drivers; JZ47xx SoCs are still officially supported and 
maintained.

Cheers,
-Paul

> >   2 files changed, 48 deletions(-)
> >   delete mode 100644 include/linux/jz4740-adc.h
> >   delete mode 100644 include/linux/power/jz4740-battery.h
>
> Patch looks fine though.
>
> Let me know if you want me to take it in via MFD.  Otherwise:
>
> Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
>
> --
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog