Re: Stackleak vs noinstr (Was: [GIT pull] objtool/core for v5.16-rc1)

From: Peter Zijlstra
Date: Wed Nov 03 2021 - 04:21:42 EST


On Wed, Nov 03, 2021 at 10:18:22AM +0300, Alexander Popov wrote:
> Yes, this is a correct approach.
>
> But I'm not sure about removing NOKPROBE_SYMBOL and notrace for
> stackleak_erase. Does the code in noinstr.text disable all those?

Yes, noinstr implies all those and more. Both kprobe and tracing are a
form of instrumentation, and hence noinstr must disallow it.