Re: [PATCH V3 4/4] crypto: ccp - Add SEV_INIT_EX support

From: Tom Lendacky
Date: Tue Nov 02 2021 - 11:38:19 EST


On 11/2/21 9:23 AM, Peter Gonda wrote:
From: David Rientjes <rientjes@xxxxxxxxxx>

+
+ nread = kernel_read(fp, sev_init_ex_nv_address, NV_LENGTH, NULL);

Not sure if you missed the previous comment, but kernel_read can return an error, shouldn't it be checked and fail on error?

Thanks,
Tom

+ dev_dbg(psp_master->dev, "SEV: read %ld bytes from NV file\n", nread);
+ filp_close(fp, NULL);
+
+ return 0;
+}
+