Re: [PATCH v1 2/2] media: dt-bindings: media: camss: Document clock-lanes property

From: Rob Herring
Date: Mon Nov 01 2021 - 16:30:26 EST


On Mon, Oct 25, 2021 at 12:33:22PM +0200, Robert Foss wrote:
> The clock-lanes property corresponds to a hardware register field
> that is required to be set, in order to enable the CSI clock signal.
>
> The physical lane of the clock signal is not programmable, but only
> togglable On or Off, which what BIT(7) of the
> CSIPHY_3PH_CMN_CSI_COMMON_CTRLn(5) register controls.
>
> Signed-off-by: Robert Foss <robert.foss@xxxxxxxxxx>
> ---
> .../devicetree/bindings/media/qcom,msm8996-camss.yaml | 5 +++++
> .../devicetree/bindings/media/qcom,sdm660-camss.yaml | 5 +++++
> .../devicetree/bindings/media/qcom,sdm845-camss.yaml | 5 +++++
> 3 files changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> index 38be41e932f0..d4da1fad12cf 100644
> --- a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> @@ -106,6 +106,11 @@ properties:
>
> properties:
> clock-lanes:
> + description:
> + The index of the clock-lane is not programmable by
> + the hardware, but is required to define a CSI port.
> + Lane 7 reflects the hardware register field that enables
> + the clock lane.

If it is fixed, then it should not be required. Fix the required part.

> items:
> - const: 7

I don't know how we let that in, but this should be the lane number.
Each binding can't be making up its own interpretation.

Rob