Re: [PATCH 1/1] staging: vchiq: Replace global state with per device state

From: kernel test robot
Date: Mon Nov 01 2021 - 12:11:14 EST


Hi Ojaswin,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on next-20211101]
[cannot apply to v5.15]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Ojaswin-Mujoo/vchiq-Replacing-global-structs-with-per-device/20211101-191153
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 10508ae08ed8ce8794785194ad7309f1437d43fd
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/7f81de8bb73f7a7d9d0a0898dbe0144d40e39254
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Ojaswin-Mujoo/vchiq-Replacing-global-structs-with-per-device/20211101-191153
git checkout 7f81de8bb73f7a7d9d0a0898dbe0144d40e39254
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arc

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:465:5: error: no previous prototype for 'vchiq_platform_init' [-Werror=missing-prototypes]
465 | int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state)
| ^~~~~~~~~~~~~~~~~~~
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:593:1: error: no previous prototype for 'vchiq_platform_get_arm_state' [-Werror=missing-prototypes]
593 | vchiq_platform_get_arm_state(struct vchiq_state *state)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:33:
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c: In function 'service_callback':
>> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h:106:33: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
106 | #define DEBUG_INITIALISE(local) int *debug_ptr = (local)->debug
| ^~~
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:1086:9: note: in expansion of macro 'DEBUG_INITIALISE'
1086 | DEBUG_INITIALISE(state->local);
| ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors


vim +106 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h

71bad7f086419d popcornmix 2013-07-02 105
8dd56723240e43 Gaston Gonzalez 2021-10-24 @106 #define DEBUG_INITIALISE(local) int *debug_ptr = (local)->debug
71bad7f086419d popcornmix 2013-07-02 107 #define DEBUG_TRACE(d) \
35b7ebda57affc Michael Zoran 2016-10-19 108 do { debug_ptr[DEBUG_ ## d] = __LINE__; dsb(sy); } while (0)
71bad7f086419d popcornmix 2013-07-02 109 #define DEBUG_VALUE(d, v) \
35b7ebda57affc Michael Zoran 2016-10-19 110 do { debug_ptr[DEBUG_ ## d] = (v); dsb(sy); } while (0)
71bad7f086419d popcornmix 2013-07-02 111 #define DEBUG_COUNT(d) \
35b7ebda57affc Michael Zoran 2016-10-19 112 do { debug_ptr[DEBUG_ ## d]++; dsb(sy); } while (0)
71bad7f086419d popcornmix 2013-07-02 113

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip