Re: [PATCH v4 5/6] PCI: imx6: Fix the regulator dump when link never came up

From: Mark Brown
Date: Mon Nov 01 2021 - 11:36:42 EST


On Mon, Nov 01, 2021 at 02:17:57PM +0800, Richard Zhu wrote:

> When PCIe PHY link never came up and vpcie regulator is present, there
> would be following dump when try to put the regulator.
> Add a new host_exit() callback for i.MX PCIe driver to disable this
> regulator and fix this dump when link never came up.

This looks like a good improvement, though it still looks like there are
issues given the checks for the regulator being NULL. This might be
better fixed as a separate patch though.

Attachment: signature.asc
Description: PGP signature