Re: [PATCH v7 00/11] extend task comm from 16 to 24

[Yafang Shao]

On Mon, Nov 1, 2021 at 8:46 PM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
>
> On Mon, Nov 01, 2021 at 06:04:08AM +0000, Yafang Shao wrote:
> > There're many truncated kthreads in the kernel, which may make trouble
> > for the user, for example, the user can't get detailed device
> > information from the task comm.
> >
> > This patchset tries to improve this problem fundamentally by extending
> > the task comm size from 16 to 24, which is a very simple way.
>
> It can't be that simple if we're on v7 and at 11 patches!
>

Most of the changes are because of hard-coded 16 that can't be easily grepped.
In these 11 patches, patch #1, #2, #4, #5, #6, #7 and #9 are cleanups,
which can be a different patchset.

The core changes of these patchset are patch #3, #8 and #10.

#11 can also be a seperate patch.

> It would be helpful if you included links to earlier postings.  I can
> only find v5 and v6 in my inbox, so I fear I'm going to re-ask some
> questions which were already answered.
>

v1: https://lore.kernel.org/lkml/20210929115036.4851-1-laoar.shao@xxxxxxxxx/
v2: https://lore.kernel.org/lkml/20211007120752.5195-1-laoar.shao@xxxxxxxxx/
v3: https://lore.kernel.org/lkml/20211010102429.99577-1-laoar.shao@xxxxxxxxx/
v4: https://lore.kernel.org/lkml/20211013102346.179642-1-laoar.shao@xxxxxxxxx/
v5: https://lore.kernel.org/lkml/20211021034516.4400-1-laoar.shao@xxxxxxxxx/
v6: https://lore.kernel.org/lkml/20211025083315.4752-1-laoar.shao@xxxxxxxxx/


> Why can't we shorten the names of these kthreads?  You didn't
> give any examples, so I can't suggest any possibilities.
>

Take 'jbd2/nvme0n1p2-' for example, that's a nice name, which gives a
good description via the name.
And I don't think it is a good idea to shorten its name.

-- 
Thanks
Yafang