Re: [PATCH 2/4] hugetlb: Replace the obsolete hugetlb_instantiation_mutex in the comments

From: Mike Kravetz
Date: Fri Oct 22 2021 - 16:45:07 EST


On 10/20/21 11:31 PM, Baolin Wang wrote:
> After commit 8382d914ebf7 ("mm, hugetlb: improve page-fault scalability"),
> the hugetlb_instantiation_mutex lock had been replaced by
> hugetlb_fault_mutex_table to serializes faults on the same logical page.
> Thus update the obsolete hugetlb_instantiation_mutex related comments.
>
> Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>
> ---
> mm/hugetlb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks!

Reviewed-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx>

--
Mike Kravetz

>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index ee0db48..8902b07 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -5012,7 +5012,7 @@ static void unmap_ref_private(struct mm_struct *mm, struct vm_area_struct *vma,
>
> /*
> * Hugetlb_cow() should be called with page lock of the original hugepage held.
> - * Called with hugetlb_instantiation_mutex held and pte_page locked so we
> + * Called with hugetlb_fault_mutex_table held and pte_page locked so we
> * cannot race with other handlers or page migration.
> * Keep the pte_same checks anyway to make transition from the mutex easier.
> */
>