Re: [Outreachy kernel] [PATCH 5/5] staging: vt6655: Rename `byRFType` variable

From: Karolina Drobnik
Date: Fri Oct 22 2021 - 11:58:10 EST


Hi Praveen,

Thanks for taking a look at my patch.

On Fri, 2021-10-22 at 19:56 +0530, Praveen Kumar wrote:
> IMO, probably we can sync RFbSelectChannel as well with similar
> notation in another patch.
>
> >  bool RFbInit(struct vnt_private *priv);
> > -bool RFvWriteWakeProgSyn(struct vnt_private *priv, unsigned char
> > byRFType, u16 channel);
> > +bool RFvWriteWakeProgSyn(struct vnt_private *priv, unsigned char
> > rf_type, u16 channel);
> >  bool RFbSetPower(struct vnt_private *priv, unsigned int rate, u16
> > uCH);
> >  bool RFbRawSetPower(struct vnt_private *priv, unsigned char byPwr,
> >                     unsigned int rate);

That's a good idea. I plan to clean up `RFvWriteWakeProgSyn` completely
first and then I can move on to this one.


Thanks,
Karolina