Re: [PATCH] scsi: bnx2fc: Make use of the helper macro kthread_run()

[John Garry]

On 21/10/2021 09:42, Cai Huoqing wrote:
> Repalce kthread_create/wake_up_process() with kthread_run()

Replace

> to simplify the code.
>
> Signed-off-by: Cai Huoqing <caihuoqing@xxxxxxxxx>
> ---
>   drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> index 71fa62bd3083..975512511a60 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> @@ -2723,9 +2723,8 @@ static int __init bnx2fc_mod_init(void)
>   
>   	bg = &bnx2fc_global;
>   	skb_queue_head_init(&bg->fcoe_rx_list);
> -	l2_thread = kthread_create(bnx2fc_l2_rcv_thread,
> -				   (void *)bg,
> -				   "bnx2fc_l2_thread");
> +	l2_thread = kthread_run(bnx2fc_l2_rcv_thread,
> +				(void *)bg, "bnx2fc_l2_thread");
>   	if (IS_ERR(l2_thread)) {
>   		rc = PTR_ERR(l2_thread);
>   		goto free_wq;

Are you then supposed to remove the wake_up_process() call also (not shown)?

>