Re: [PATCH v1] usb: xhci: tegra: Check padctrl interrupt presence in device tree

[Dmitry Osipenko]

21.10.2021 22:14, Alan Stern пишет:
...
>>> Should USB keyboard be able to wake up every HC or it's a
>>> machine-specific feature?
>>
>> I mean whether key press should wake up HC if wake-up is enabled for the
>> keyboard device.
> 
> Yes, it should.  More specifically, if the keyboard is capable of 
> generating wakeup requests, and wakeup is enabled for both the keyboard 
> device and the HC, then the keyboard should be able to wake up the 
> system from suspend.  Some HCs or systems might not support this 
> capability, however.
> 
>>> I'm asking because wakeup works on a typical
>>> Intel hardware, but doesn't work on older Tegra SoCs that use Chipidea
>>> controller. It's not obvious to me whether this is something that
>>> firmware handles for Intel or it's broken on Tegra. Could you please
>>> clarify? If it should work for every HC, then I may try to take a closer
>>> look.
> 
> If the hardware/firmware can support it then it should work.  I don't 
> know what's going on with your older Tegra SoCs; it's possible there is 
> a bug in the driver.

I'll take a closer look then, thank you.