Re: [PATCH] btrfs: simplify redundant logic judgment

From: David Sterba
Date: Thu Oct 21 2021 - 11:27:14 EST


On Wed, Oct 20, 2021 at 12:23:41AM -0700, Qing Wang wrote:
> From: Wang Qing <wangqing@xxxxxxxx>
>
> A || (!A && B) is equal to A || B
>
> Signed-off-by: Wang Qing <wangqing@xxxxxxxx>
> ---
> fs/btrfs/inode.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index 07ba22dd..e0d2660
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -2011,8 +2011,7 @@ int btrfs_run_delalloc_range(struct btrfs_inode *inode, struct page *locked_page
> * to use run_delalloc_nocow() here, like for regular
> * preallocated inodes.
> */
> - ASSERT(!zoned ||
> - (zoned && btrfs_is_data_reloc_root(inode->root)));
> + ASSERT(!zoned || btrfs_is_data_reloc_root(inode->root));

Thanks, but somebody already sent such patch and we'd like to keep it as
it is for clarity.