Re: Re: [PATCH 0/6] kthread: Add the helper macro kthread_run_on_cpu()

[Bernard Metzler]

-----"Cai Huoqing" <caihuoqing@xxxxxxxxx> wrote: -----

>To: "Bernard Metzler" <BMT@xxxxxxxxxxxxxx>
>From: "Cai Huoqing" <caihuoqing@xxxxxxxxx>
>Date: 10/21/2021 04:08PM
>Cc: "Doug Ledford" <dledford@xxxxxxxxxx>, "Jason Gunthorpe"
><jgg@xxxxxxxx>, "Davidlohr Bueso" <dave@xxxxxxxxxxxx>, "Paul E.
>McKenney" <paulmck@xxxxxxxxxx>, "Josh Triplett"
><josh@xxxxxxxxxxxxxxxx>, "Steven Rostedt" <rostedt@xxxxxxxxxxx>,
>"Mathieu Desnoyers" <mathieu.desnoyers@xxxxxxxxxxxx>, "Lai Jiangshan"
><jiangshanlai@xxxxxxxxx>, "Joel Fernandes" <joel@xxxxxxxxxxxxxxxxx>,
>"Ingo Molnar" <mingo@xxxxxxxxxx>, "Daniel Bristot de Oliveira"
><bristot@xxxxxxxxxx>, <linux-rdma@xxxxxxxxxxxxxxx>,
><linux-kernel@xxxxxxxxxxxxxxx>, <rcu@xxxxxxxxxxxxxxx>
>Subject: [EXTERNAL] Re: [PATCH 0/6] kthread: Add the helper macro
>kthread_run_on_cpu()
>
>On 21 10月 21 13:48:15, Bernard Metzler wrote:
>> -----"Cai Huoqing" <caihuoqing@xxxxxxxxx> wrote: -----
>> 
>> >To: <caihuoqing@xxxxxxxxx>
>> >From: "Cai Huoqing" <caihuoqing@xxxxxxxxx>
>> >Date: 10/21/2021 02:02PM
>> >Cc: "Bernard Metzler" <bmt@xxxxxxxxxxxxxx>, "Doug Ledford"
>> ><dledford@xxxxxxxxxx>, "Jason Gunthorpe" <jgg@xxxxxxxx>,
>"Davidlohr
>> >Bueso" <dave@xxxxxxxxxxxx>, "Paul E. McKenney"
><paulmck@xxxxxxxxxx>,
>> >"Josh Triplett" <josh@xxxxxxxxxxxxxxxx>, "Steven Rostedt"
>> ><rostedt@xxxxxxxxxxx>, "Mathieu Desnoyers"
>> ><mathieu.desnoyers@xxxxxxxxxxxx>, "Lai Jiangshan"
>> ><jiangshanlai@xxxxxxxxx>, "Joel Fernandes"
><joel@xxxxxxxxxxxxxxxxx>,
>> >"Ingo Molnar" <mingo@xxxxxxxxxx>, "Daniel Bristot de Oliveira"
>> ><bristot@xxxxxxxxxx>, <linux-rdma@xxxxxxxxxxxxxxx>,
>> ><linux-kernel@xxxxxxxxxxxxxxx>, <rcu@xxxxxxxxxxxxxxx>
>> >Subject: [EXTERNAL] [PATCH 0/6] kthread: Add the helper macro
>> >kthread_run_on_cpu()
>> >
>> >the helper macro kthread_run_on_cpu() inculdes
>> >kthread_create_on_cpu/wake_up_process().
>> >In some cases, use kthread_run_on_cpu() directly instead of
>> >kthread_create_on_node/kthread_bind/wake_up_process() or
>> >kthread_create_on_cpu/wake_up_process() or
>> >kthreadd_create/kthread_bind/wake_up_process() to simplify the
>code.
>> 
>> I do not see kthread_bind() being covered by the helper,
>> as claimed? rcutorture, ring-buffer, siw are using it in
>> the code potentially being replaced by the helper.
>> kthread_bind() is best to be called before thread starts
>> running, so should be part of it.
>Hi,
>kthread_bind() is already part of kthread_create_on_cpu which is
>called by kthread_run_on_cpu() here.
>

Indeed! Thanks, Bernard.

>Thanks,
>Cai.
>> 
>> Thanks,
>> Bernard.
>> >
>> >Cai Huoqing (6):
>> >  kthread: Add the helper macro kthread_run_on_cpu()
>> >  RDMA/siw: Make use of the helper macro kthread_run_on_cpu()
>> >  ring-buffer: Make use of the helper macro kthread_run_on_cpu()
>> >  rcutorture: Make use of the helper macro kthread_run_on_cpu()
>> >  trace/osnoise: Make use of the helper macro kthread_run_on_cpu()
>> >  trace/hwlat: Make use of the helper macro kthread_run_on_cpu()
>> >
>> > drivers/infiniband/sw/siw/siw_main.c |  7 +++----
>> > include/linux/kthread.h              | 22 ++++++++++++++++++++++
>> > kernel/rcu/rcutorture.c              |  7 ++-----
>> > kernel/trace/ring_buffer.c           |  7 ++-----
>> > kernel/trace/trace_hwlat.c           |  6 +-----
>> > kernel/trace/trace_osnoise.c         |  3 +--
>> > 6 files changed, 31 insertions(+), 21 deletions(-)
>> >
>> >-- 
>> >2.25.1
>> >
>> >
>