Re: [PATCH v2 0/2] perf jevents: Enable build warnings

[John Garry]

On 21/10/2021 13:55, Arnaldo Carvalho de Melo wrote:
> Em Thu, Oct 21, 2021 at 05:16:43PM +0800, John Garry escreveu:
> > Currently jevents builds without any complier warning flags enabled. So
> > use newly-defined HOSTCFLAGS, which comes from EXTRA_WARNINGS.
> >
> > Changes for v2:
> > - Add Werror, Wall, and Wextra (James Clark suggestion)
>
> Thanks, applied.

Hi Arnaldo,

Can you please wait until I check the review response from jirka?

Thanks

> - Arnaldo
>
>   
> > Baseline is acme perf/core + mainline commit b94729919db2 ("perf jevents:
> > Free the sys_event_tables list after processing entries"):
> >
> > 680453e63302 perf jevents: Free the sys_event_tables list after processing entries
> > be8ecc57f180 (origin/perf/core) perf srcline: Use long-running addr2line per DSO
> > 2b775152bbe8 perf tests vmlinux-kallsyms: Ignore hidden symbols
> >
> > John Garry (2):
> >    perf jevents: Fix some would-be warnings
> >    perf jevents: Enable warnings through HOSTCFLAGS
> >
> >   tools/perf/Makefile.config      |  5 +++++
> >   tools/perf/Makefile.perf        |  2 +-
> >   tools/perf/pmu-events/Build     |  2 +-
> >   tools/perf/pmu-events/jevents.c | 10 ++++------
> >   4 files changed, 11 insertions(+), 8 deletions(-)
> >
> > --
> > 2.17.1