RE: [PATCH v2 2/2] dt-bindings: Add SC7280 compatible string

[quic_sbillaka]

Hi Doug,

Sorry about that, this is the first time I am posting changes upstream and still getting hold of conventions.

I think I misinterpreted your subject line comment and changed the just title to include dp-controller. I will correct it in the next version.

sc7280-dp will be added later when dp support for sc7280 will be posted. I will reply on the feedback email from Stephen.

Thank you,
Sankeerth

-----Original Message-----
From: Doug Anderson <dianders@xxxxxxxxxxxx> 
Sent: Wednesday, October 20, 2021 11:11 PM
To: quic_sbillaka <quic_sbillaka@xxxxxxxxxxx>
Cc: dri-devel <dri-devel@xxxxxxxxxxxxxxxxxxxxx>; linux-arm-msm <linux-arm-msm@xxxxxxxxxxxxxxx>; freedreno <freedreno@xxxxxxxxxxxxxxxxxxxxx>; LKML <linux-kernel@xxxxxxxxxxxxxxx>; Sankeerth Billakanti <sbillaka@xxxxxxxxxxxxxx>; Rob Clark <robdclark@xxxxxxxxx>; Sean Paul <seanpaul@xxxxxxxxxxxx>; Stephen Boyd <swboyd@xxxxxxxxxxxx>; Kalyan Thota <kalyan_t@xxxxxxxxxxxxxx>; Abhinav Kumar <abhinavk@xxxxxxxxxxxxxx>; Kuogee Hsieh <khsieh@xxxxxxxxxxxxxx>; Krishna Manikandan <mkrishn@xxxxxxxxxxxxxx>
Subject: Re: [PATCH v2 2/2] dt-bindings: Add SC7280 compatible string

WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros.

Hi,

On Wed, Oct 20, 2021 at 5:14 AM Sankeerth Billakanti <quic_sbillaka@xxxxxxxxxxx> wrote:
>
> From: Sankeerth Billakanti <sbillaka@xxxxxxxxxxxxxx>
>
> The Qualcomm SC7280 platform supports an eDP controller, add 
> compatible string for it to dp-controller.
>
> Signed-off-by: Sankeerth Billakanti <quic_sbillaka@xxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 
> +
>  1 file changed, 1 insertion(+)

I think you ignored some of the feedback that was given on v1. Perhaps you could go back and re-read that feedback? See the replies to:

https://lore.kernel.org/r/1628726882-27841-3-git-send-email-sbillaka@xxxxxxxxxxxxxx/

For one, ${SUBJECT} needs updating. It's probably as simple as adding the "msm/dp" tag, like:

dt-bindings: msm/dp: Add SC7280 compatible string

For another, Stephen requested that you add "sc7280-dp" too.