[RFC PATCH] sched/fair: use max_spare_cap_cpu if it is more energy efficient

From: brookxu
Date: Thu Oct 21 2021 - 04:23:24 EST


From: Chunguang Xu <brookxu@xxxxxxxxxxx>

When debugging EAS, I found that if the task is migrated to
max_spare_cap_cpu, even if the power consumption of pd is lower,
we still put the task on prev_cpu. Maybe we should fix it.

Signed-off-by: Chunguang Xu <brookxu@xxxxxxxxxxx>
---
kernel/sched/fair.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index ff69f245b939..2ae7e03de6d2 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -6867,8 +6867,10 @@ static int find_energy_efficient_cpu(struct task_struct *p, int prev_cpu)
/* Evaluate the energy impact of using max_spare_cap_cpu. */
if (max_spare_cap_cpu >= 0) {
cur_delta = compute_energy(p, max_spare_cap_cpu, pd);
- if (cur_delta < base_energy_pd)
+ if (cur_delta < base_energy_pd) {
+ target = max_spare_cap_cpu;
goto unlock;
+ }
cur_delta -= base_energy_pd;
if (cur_delta < best_delta) {
best_delta = cur_delta;
--
2.30.0