Re: [PATCH v7 1/5] ARM: dts: aspeed: Drop reg-io-width from LPC nodes

From: Joel Stanley
Date: Thu Oct 21 2021 - 02:54:42 EST


On Thu, 21 Oct 2021 at 06:48, Joel Stanley <joel@xxxxxxxxx> wrote:
>
> On Thu, 21 Oct 2021 at 06:37, ChiaWei Wang <chiawei_wang@xxxxxxxxxxxxxx> wrote:
> > However, like Rob mentioned, when doing 'make dtbs_check', there is a warning:
> >
> > /builds/robherring/linux-dt-review/arch/arm/boot/dts/aspeed-ast2500-evb.dt.yaml:
> > lpc@1e789000: 'ibt@140', 'kcs@114', 'kcs@24', 'kcs@28', 'kcs@2c', 'lhc@a0', 'reg-io-width' do not match any of the regexes:
> > '^lpc-ctrl@[0-9a-f]+$', '^lpc-snoop@[0-9a-f]+$', '^reset-controller@[0-9a-f]+$', 'pinctrl-[0-9]+'
> > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
> >
> > As part of this series has been applied, maybe we can fix this later?

FWIW, this fixes the warnings for me;

--- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
+++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
@@ -56,6 +56,9 @@ properties:

ranges: true

+ reg-io-width:
+ const: 4
+
patternProperties:
"^lpc-ctrl@[0-9a-f]+$":
type: object
@@ -144,6 +147,9 @@ patternProperties:
$ref: /schemas/types.yaml#/definitions/uint32-array
description: The LPC I/O ports to snoop

+ clocks:
+ maxItems: 1
+
required:
- compatible
- interrupts

make ARCH=arm CROSS_COMPILE="arm-linux-gnueabi-" dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml

If you are able to test this and send a patch that would be appreciated.

Cheers,

Joel