Re: [PATCH] Staging: iio: adc: ad7280a: fixed coding style

From: Jonathan Cameron
Date: Wed Oct 20 2021 - 16:26:59 EST


On Wed, 20 Oct 2021 01:10:27 -0500
sesankm <sesank.mallikarjuna@xxxxxxxxx> wrote:

> fixed issue with coding style
>
> Signed-off-by: sesankm <26676400+sesankm@xxxxxxxxxxxxxxxxxxxxxxxx>

Ah. Our 'favourite' false positive. Take a look at what that macro
is doing..

There is a series waiting for review that removes this code anyway...
https://patchwork.kernel.org/project/linux-iio/list/?series=499867

> ---
> drivers/staging/iio/adc/ad7280a.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> index fef0055b8990..473f95118214 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -829,14 +829,14 @@ static irqreturn_t ad7280_event_handler(int irq, void *private)
> * The function argument is stringified and doesn't need a fix
> */
> static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
> - in_voltage-voltage_thresh_low_value,
> + in_voltage - voltage_thresh_low_value,
> 0644,
> ad7280_read_channel_config,
> ad7280_write_channel_config,
> AD7280A_CELL_UNDERVOLTAGE);
>
> static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
> - in_voltage-voltage_thresh_high_value,
> + in_voltage - voltage_thresh_high_value,
> 0644,
> ad7280_read_channel_config,
> ad7280_write_channel_config,