Re: [PATCH] Revert "watchdog: iTCO_wdt: Account for rebooting on second timeout"

From: Guenter Roeck
Date: Wed Oct 20 2021 - 15:44:15 EST


Wim,

On Thu, Oct 07, 2021 at 05:33:02PM -0700, Guenter Roeck wrote:
> This reverts commit cb011044e34c ("watchdog: iTCO_wdt: Account for
> rebooting on second timeout") and commit aec42642d91f ("watchdog: iTCO_wdt:
> Fix detection of SMI-off case") since those patches cause a regression
> on certain boards (https://bugzilla.kernel.org/show_bug.cgi?id=213809).
>
> While this revert may result in some boards to only reset after twice
> the configured timeout value, that is still better than a watchdog reset
> after half the configured value.
>
> Fixes: cb011044e34c ("watchdog: iTCO_wdt: Account for rebooting on second timeout")
> Fixes: aec42642d91f ("watchdog: iTCO_wdt: Fix detection of SMI-off case")
> Cc: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
> Cc: Mantas Mikulėnas <grawity@xxxxxxxxx>
> Reported-by: Javier S. Pedro <debbugs@xxxxxxxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Any chance you can send a pull request with this patch prior to the v5.15
release ?

Thanks,
Guenter