Re: [PATCH v14 00/11] Add support for Hikey 970 PCIe

From: Bjorn Helgaas
Date: Wed Oct 20 2021 - 15:02:27 EST


On Wed, Oct 20, 2021 at 06:41:42AM +0100, Mauro Carvalho Chehab wrote:
> Em Tue, 19 Oct 2021 14:27:58 -0500
> Bjorn Helgaas <helgaas@xxxxxxxxxx> escreveu:
>
> > On Tue, Oct 19, 2021 at 07:06:37AM +0100, Mauro Carvalho Chehab wrote:
> >
> > > Mauro Carvalho Chehab (11):
> > > PCI: kirin: Reorganize the PHY logic inside the driver
> > > PCI: kirin: Add support for a PHY layer
> > > PCI: kirin: Use regmap for APB registers
> > > PCI: kirin: Add support for bridge slot DT schema
> > > PCI: kirin: give more time for PERST# reset to finish
> > > PCI: kirin: Add Kirin 970 compatible
> > > PCI: kirin: Add MODULE_* macros
> > > PCI: kirin: Allow building it as a module
> > > PCI: kirin: Add power_off support for Kirin 960 PHY
> > > PCI: kirin: fix poweroff sequence
> > > PCI: kirin: Allow removing the driver
> >
> > Don't repost for this, but if you have occasion to repost for other
> > reasons, two of these are not capitalized like the others:
> >
> > > PCI: kirin: give more time for PERST# reset to finish
> > > PCI: kirin: fix poweroff sequence
> >
> > These are write-once for you, but I'll be reading them many times in
> > the future and they're minor distractions.
>
> Ok, changed on my working repository. On media and on other subsystems
> I contribute regularly, the practice is just the opposite: to use
> lowercase after colons.

Thanks. I wouldn't mind a kernel-wide convention, but there isn't
one. I just try to pay attention to whatever convention there is for
a given file or subsystem.

Bjorn