Re: [PATCH v4 1/2] socfpga: dts: move arria10 aliases to socfpga_arria10.dtsi

From: Paweł Anikiel
Date: Wed Oct 20 2021 - 10:52:44 EST


On Wed, Oct 20, 2021 at 3:33 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> On Tue, Oct 19, 2021 at 4:12 PM Paweł Anikiel <pan@xxxxxxxxxxxx> wrote:
> >
> > socfpga_arria10_socdk.dtsi declares aliases which will most likely
> > be used by other arria10 boards in the exact same way. move these
> > aliases to the parent file.
> >
> > Signed-off-by: Paweł Anikiel <pan@xxxxxxxxxxxx>
>
> No, please move them into the .dts files instead for consistency.
>
> Each board may use a different subset of them, or have them
> numbered differently, so keep it out of the .dtsi file.
>
> Arnd

Thank you for your remark. The aliases per .dts file were in the v3
patch, however this change was explicitly requested. I will bring that
back and resubmit.

Thanks, Paweł.