Re: [PATCH] s390: replace snprintf in show functions with sysfs_emit

From: Stefan Haberland
Date: Wed Oct 20 2021 - 10:44:11 EST


Am 15.10.21 um 08:50 schrieb Qing Wang:
show() must not use snprintf() when formatting the value to be
returned to user space.

Fix the coccicheck warnings:
WARNING: use scnprintf or sprintf.

Use sysfs_emit instead of scnprintf or sprintf makes more sense.

Signed-off-by: Qing Wang <wangqing@xxxxxxxx>
---
drivers/s390/block/dasd_devmap.c | 74 ++++++++++++++++++++--------------------


Thanks for the DASD changes. While I am totally fine with the change itself I agree with Joe's remark.
Would you like to improve your patch? Otherwise I can add a small follow on patch. Just let me know.