Re: [PATCH v3 1/4] mtd: rawnand: nand_bbt: hide suspend/resume hooks while scanning bbt

From: Miquel Raynal
Date: Wed Oct 20 2021 - 05:12:16 EST


Hi Boris,

boris.brezillon@xxxxxxxxxxxxx wrote on Wed, 20 Oct 2021 11:03:03 +0200:

> On Wed, 20 Oct 2021 11:01:32 +0200
> Sean Nyekjaer <sean@xxxxxxxxxx> wrote:
>
> > On Wed, Oct 20, 2021 at 10:53:26AM +0200, Boris Brezillon wrote:
> > > On Wed, 20 Oct 2021 10:45:31 +0200
> > > Sean Nyekjaer <sean@xxxxxxxxxx> wrote:
> > >
> > > > From: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>
> > > >
> > > > The BBT scan logic use the MTD helpers before the MTD layer had a
> > > > chance to initialize the device, and that leads to issues when
> > > > accessing the uninitialized suspend lock. Let's temporarily set the
> > > > suspend/resume hooks to NULL to skip the lock acquire/release step.
> > > >
> > > > Fixes: 013e6292aaf5 ("mtd: rawnand: Simplify the locking")
> > > > Tested-by: Sean Nyekjaer <sean@xxxxxxxxxx>
> > >
> > > It's missing our Signed-off-by tags.
> > >
> >
> > Patch is from you ;)
> > If you are okay with it, I will add your Signed-off-by tag.
>
> You should add both (mine and yours).

And put the one matching the author (Boris') before the other (yours).