Re: [PATCH] kselftests: ftrace: limit the executing time by reading from cached trace

From: Masami Hiramatsu
Date: Tue Oct 19 2021 - 22:55:29 EST


On Tue, 19 Oct 2021 22:34:54 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Wed, 20 Oct 2021 11:20:27 +0900
> Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
>
> > Hmm, by the way, shouldn't we set this feature by default?
> > There are many "cat trace | grep ..." style test code in ftracetest just for
> > checking whether the event is recorded. At least for the ftracetest, it should
> > be set unless the testcase is explicitly disable it.
>
> For testing, sure.
>
> I was criticized by the BPF folks about tracing stopping when the trace
> file was being read. So for normal operations, it doesn't pause, because
> that "confuses" people (so I am told).

OK, I got it.

Here is the patch to enable it by default for ftracetest :)

Thanks!