Re: [QUESTION] Performance deterioration caused by commit 85f726a35e504418

From: Yang Jihong
Date: Tue Oct 19 2021 - 22:00:34 EST


Hi, Steve and Tom

On 2021/10/20 2:38, Zanussi, Tom wrote:
On 10/19/2021 1:10 PM, Steven Rostedt wrote:
On Tue, 19 Oct 2021 12:30:28 -0500
"Zanussi, Tom" <tom.zanussi@xxxxxxxxxxxxxxx> wrote:

So anyway, as far as the histograms go, I think optimizing the two
changes in 85f726a35e504418 while ignoring trailing garbage can be done
without affecting the histogram correctness.

So, none of that is exported to user space?

I meant just that any optimization of those two things that ignored the
trailing garbage wouldn't affect the histogram keys.

But yeah I think you're correct that ignoring it in the case of
saved_cmdlines wouldn't be a problem either but it would be in the case of
max_buffer since that's exported by the ring buffer.

OK. Thanks very much for your patience. :)

Kind regards,
Jihong

Tom


-- Steve

.