Re: [PATCH 1/5] tracing: Add support for creating hist trigger variables from literal

[Kalesh Singh]

On Tue, Oct 19, 2021 at 2:26 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> On Tue, 19 Oct 2021 14:21:04 -0700
> Kalesh Singh <kaleshsingh@xxxxxxxxxx> wrote:
>
> > Addition and subtraction are already supported operations. The use
> > case given in Documentation/trace/histogram.rst is for calculating
> > latencies. I don't have a use case where the constants may be needed
> > in the addition/subtraction, but for simplicity and completeness we
> > support them for all operations.
>
> Perhaps we should state that it's mostly added for completeness then.

Good point. I'll update the commit message to clarify it.

Thanks,
Kalesh
>
> Thanks,
>
> -- Steve