Re: [PATCH net-next v2] net: marvell: prestera: add firmware v4.0 support

[Volodymyr Mytnyk [C]]

Hi Andrew,

> On Tue, Oct 19, 2021 at 09:03:43AM +0300, Volodymyr Mytnyk wrote:
> > From: Volodymyr Mytnyk <vmytnyk@xxxxxxxxxxx>
> >
> > Add firmware (FW) version 4.0 support for Marvell Prestera
> > driver. This FW ABI will be compatible with future Prestera
> > driver versions and features.
> >
> > The previous FW support is dropped due to significant changes
> > in FW ABI, thus this version of Prestera driver will not be
> > compatible with previous FW versions.
> 
> So we are back to breaking any switch already deployed using the
> driver with the older firmware. Bricks in broom closets, needing
> physical access to fix them. Was nothing learnt from the upgrade from
> v2 to v3 with its ABI breakage and keeping backwards support for one
> version? Do you see other vendors making ABI breaking changes to there
> firmware?

- Major changes have been made to new v4.0 FW ABI to add support of new features,
  introduce the stability of the FW ABI and ensure better forward compatibility
  for the future vesrions. So, the idea was to break support and focus on more
  stable FW instead of supporting old version with very minimal and limited set
  of features/capabilities.

- For backward support, the addition compatability layer is required in the 
  driver which will have two different codebase under "if FW-VER elif FW-VER else"
  conditions that will be removed in the future.

- All current platforms using this driver have dedicated OOB mgmt port, thus the
  user still be able to do upgrade of the FW. So, no "Bricks in broom closets" :).
  Also, this is Marvell guidelines to have OOB for the future platforms.

> 
> Why would anybody decide to use Marvell, when you can use Microchip
> devices an avoid all these problems?
> 
>         Andrew
>

Volodymyr