Re: [PATCH] scsi: core: return -ENOMEM on ips_init_phase1() allocation failure

[James Bottomley]

On Tue, 2021-10-19 at 18:50 +0800, Jiapeng Chong wrote:
> From: chongjiapeng <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> 
> Fixes the following smatch warning:
> 
> drivers/scsi/ips.c:6901 ips_init_phase1() warn: returning -1 instead
> of -ENOMEM is sloppy.

Really, like megaraid, it's not.  ips_init_phase1() returns either
Success or -1.  If it returns -1, that gets translated to -ENODEV so,
again, we'd lose this nuanced return completely.

James