Re: [PATCH] mmc: winbond: don't build on M68K

From: Ulf Hansson
Date: Tue Oct 19 2021 - 07:00:14 EST


On Sun, 17 Oct 2021 at 19:59, Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> The Winbond MMC driver fails to build on ARCH=m68k so prevent
> that build config. Silences these build errors:
>
> ../drivers/mmc/host/wbsd.c: In function 'wbsd_request_end':
> ../drivers/mmc/host/wbsd.c:212:28: error: implicit declaration of function 'claim_dma_lock' [-Werror=implicit-function-declaration]
> 212 | dmaflags = claim_dma_lock();
> ../drivers/mmc/host/wbsd.c:215:17: error: implicit declaration of function 'release_dma_lock'; did you mean 'release_task'? [-Werror=implicit-function-declaration]
> 215 | release_dma_lock(dmaflags);
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Pierre Ossman <pierre@xxxxxxxxx>
> Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Cc: linux-mmc@xxxxxxxxxxxxxxx
> Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Cc: linux-m68k@xxxxxxxxxxxxxxxxxxxx
> Cc: Arnd Bergmann <arnd@xxxxxxxx>

Applied for fixes, thanks!

Kind regards
Uffe

> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20211015.orig/drivers/mmc/host/Kconfig
> +++ linux-next-20211015/drivers/mmc/host/Kconfig
> @@ -508,7 +508,7 @@ config MMC_OMAP_HS
>
> config MMC_WBSD
> tristate "Winbond W83L51xD SD/MMC Card Interface support"
> - depends on ISA_DMA_API
> + depends on ISA_DMA_API && !M68K
> help
> This selects the Winbond(R) W83L51xD Secure digital and
> Multimedia card Interface.