RE: [PATCH -next] rtw89: remove unneeded semicolon

From: Pkshih
Date: Tue Oct 19 2021 - 05:14:13 EST



> -----Original Message-----
> From: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
> Sent: Tuesday, October 19, 2021 3:55 PM
> To: davem@xxxxxxxxxxxxx
> Cc: kuba@xxxxxxxxxx; Pkshih <pkshih@xxxxxxxxxxx>; kvalo@xxxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
> Subject: [PATCH -next] rtw89: remove unneeded semicolon
>
> Eliminate the following coccicheck warning:
> ./drivers/net/wireless/realtek/rtw89/pci.c:1348:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>

Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>

> ---
> drivers/net/wireless/realtek/rtw89/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/pci.c b/drivers/net/wireless/realtek/rtw89/pci.c
> index e973101..2c94762 100644
> --- a/drivers/net/wireless/realtek/rtw89/pci.c
> +++ b/drivers/net/wireless/realtek/rtw89/pci.c
> @@ -1345,7 +1345,7 @@ static int rtw89_pci_check_mdio(struct rtw89_dev *rtwdev, u8 addr, u8 speed, u16
> default:
> rtw89_err(rtwdev, "[ERR]Error Speed %d!\n", speed);
> return -EINVAL;
> - };
> + }
> rtw89_write16(rtwdev, R_AX_MDIO_CFG, val);
> rtw89_write16_set(rtwdev, R_AX_MDIO_CFG, rw_bit);
>
> --
> 1.8.3.1