Re: [PATCH binder] binder: remove duplicate include in binder.c

From: Greg KH
Date: Tue Oct 19 2021 - 05:12:30 EST


On Tue, Oct 19, 2021 at 08:04:02AM +0000, cgel.zte@xxxxxxxxx wrote:
> From: Ran Jianping <ran.jianping@xxxxxxxxxx>
>
> 'binder_trace.h' included in 'drivers/android/binder.c'
> is duplicated.It is also included on the 6026 line.
>
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Ran Jianping <ran.jianping@xxxxxxxxxx>
> ---
> drivers/android/binder.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index 26382e982c5e..19f6247d33f5 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -6023,6 +6023,5 @@ static int __init binder_init(void)
> device_initcall(binder_init);
>
> #define CREATE_TRACE_POINTS
> -#include "binder_trace.h"
>
> MODULE_LICENSE("GPL v2");
> --
> 2.25.1
>

Did you build this code after making this change and verify that the
tracepoints still work properly?

Please fix your "robot", it is broken.

greg k-h