Re: [PATCH] KVM: cleanup allocation of rmaps and page tracking data

From: Sean Christopherson
Date: Mon Oct 18 2021 - 14:14:06 EST


On Mon, Oct 18, 2021, Paolo Bonzini wrote:
> From: David Stevens <stevensd@xxxxxxxxxxxx>
>
> Unify the flags for rmaps and page tracking data, using a
> single flag in struct kvm_arch and a single loop to go
> over all the address spaces and memslots. This avoids
> code duplication between alloc_all_memslots_rmaps and
> kvm_page_track_enable_mmu_write_tracking.
>
> Signed-off-by: David Stevens <stevensd@xxxxxxxxxxxx>
> [This patch is the delta between David's v2 and v3, with conflicts
> fixed and my own commit message. - Paolo]
> Co-developed-by: Sean Christopherson <seanjc@xxxxxxxxxx>

Checkpatch will complain about a lack of

Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>

> Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> ---

...

> + bool shadow_root_alloced;

Maybe "allocated" instead of "alloced"?