Re: [PATCH] asm-generic: bug.h: add unreachable() in BUG() for CONFIG_BUG not set

[Arnd Bergmann]

On Sun, Oct 17, 2021 at 9:27 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> On 10/17/21 12:24 PM, Arnd Bergmann wrote:
> > On Sun, Oct 17, 2021 at 9:17 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> >> On 10/17/21 12:09 PM, Arnd Bergmann wrote:
> >>> On Sun, Oct 17, 2021 at 7:49 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> >>
> >>> Did you see any other issues like this one on m68k, or the
> >>> same one on another architecture?
> >>
> >> No and no.
> >
> > Ok, maybe before we waste too much time on it, just add an extra
> > return statement to afs_dir_set_page_dirty()?
>
> I think that patch has already been rejected a few times...

Indeed, this is one I had looked at before:

https://lore.kernel.org/all/CAK8P3a3L6B9HXsOXSu9_c6pz1kN91Vig6EPsetLuYVW=M72XaQ@xxxxxxxxxxxxxx/

It seems that this version:

+#define BUG() do {                                             \
+               do {} while (1);                                \
+               unreachable();                                  \
+       } while (0)

ended up being one that didn't see any objections.

        Arnd